Fix buggy behaviour on fast enter to split blocks #10328
Closed
+104
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
force-pushed
the
try/fast-enter-fix
branch
from
5b6bc51
to
9e42c8c
Compare
ellatrix
force-pushed
the
try/fast-enter-fix
branch
from
9e42c8c
to
0162cba
Compare
ellatrix
added
[Status] In Progress
4 tasks
|
New PR: #11287. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WIP: this relies on #10297!
Also note that this fixes a bug that existed long before the new rich text value!
Fixes #6021. In master, keep enter pressed in a paragraph, and observe blocks with too many BR elements, or nested paragraph elements, or BR elements around existing text. This is caused by attaching the keydown handler too late (during TinyMCE setup), resulting in default browser behaviour executing. The solution is to attach handler on the content editable element with React as soon as the element is created.
How has this been tested?
When keeping enter pressed in a paragraph, it should create a bunch a clean, empty paragraphs.
Screenshots
Types of changes
Checklist: